Change environment variable

cryostatio · Jan 15, 2025 · b0261c7 · b0261c7
1 parent 2524613
commit b0261c7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/internal/controllers/common/resource_definitions/resource_definitions.go b/internal/controllers/common/resource_definitions/resource_definitions.go
@@ -1179,16 +1179,11 @@ func NewCoreContainer(cr *model.CryostatInstance, specs *ServiceSpecs, imageTag
 	if cr.Spec.AgentOptions != nil && cr.Spec.AgentOptions.DisableHostnameVerification {
 		envs = append(envs,
 			corev1.EnvVar{
-				Name:  "CRYOSTAT_AGENT_DISABLE_HOSTNAME_VERIFICATION",
-				Value: "true",
-			},
-			// FIXME this disables hostname verification on all HTTP clients, not only the Agent ones.
-			// This means hostname verification on the report sidecar client, if any, will also be disabled.
-			corev1.EnvVar{
+				// TODO This should eventually be replaced by an agent-specific toggle.
+				// See: https://github.com/cryostatio/cryostat/issues/778
 				Name:  "QUARKUS_REST_CLIENT_VERIFY_HOST",
 				Value: "false",
-			},
-		)
+			})
 	}
 
 	// Mount the templates specified in Cryostat CR under /opt/cryostat.d/templates.d

diff --git a/internal/test/resources.go b/internal/test/resources.go
@@ -1605,8 +1605,8 @@ func (r *TestResources) NewCoreEnvironmentVariables(reportsUrl string, ingress b
 	if r.DisableAgentHostnameVerify {
 		envs = append(envs,
 			corev1.EnvVar{
-				Name:  "CRYOSTAT_AGENT_DISABLE_HOSTNAME_VERIFICATION",
-				Value: "true",
+				Name:  "QUARKUS_REST_CLIENT_VERIFY_HOST",
+				Value: "false",
 			})
 	}