Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): add CRD option to disable hostname verification #1011

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Jan 14, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #971

Description of the change:

  • Adds a CRD option to disable hostname verification for Cryostat when connecting to agents' callback server

Motivation for the change:

  • This provides a fallback for users if the automatic hostname detection fails for the Cryostat agent in their cluster. This can happen because cluster networking is very configurable.

How to manually test:

  1. Deploy this PR
  2. Create a CR with spec.agentOptions.disableHostnameVerification set to true
  3. make sample_app_agent_injected
  4. Sample app should register properly using its IP address for the callback URL

@ebaron ebaron force-pushed the disable-agent-hostname-ver branch from b0261c7 to 856b143 Compare January 15, 2025 22:40
@ebaron ebaron marked this pull request as ready for review January 15, 2025 22:40
@ebaron ebaron requested a review from a team January 15, 2025 22:43
@ebaron
Copy link
Member Author

ebaron commented Jan 15, 2025

/build_test

Copy link

/build_test completed successfully ✅.
View Actions Run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Story] Selectively disable agent hostname verification through CRD
1 participant