Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(oci): switch builder image to ubi9 go toolset #997

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #

Description of the change:

This change adds allows the users to provide...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Insert steps here...
  2. ...

@andrewazores andrewazores marked this pull request as ready for review January 7, 2025 17:15
@andrewazores
Copy link
Member Author

/build_test

@andrewazores
Copy link
Member Author

CI failing due to the runner image being updated to a newer Ubuntu version. See cryostatio/cryostat-core#494

Copy link

github-actions bot commented Jan 7, 2025

/build_test : At least one test failed ❌.
View Actions Run.

@andrewazores
Copy link
Member Author

/build_test

Copy link

github-actions bot commented Jan 7, 2025

/build_test completed successfully ✅.
View Actions Run.

@andrewazores andrewazores requested a review from ebaron January 7, 2025 17:43
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could I get you to run make scorecard-build MANIFEST_PUSH=false bundle to bump the scorecard tag so the CI pushes a UBI-based scorecard image?

@andrewazores andrewazores merged commit 52fef0c into cryostatio:main Jan 7, 2025
5 checks passed
@andrewazores andrewazores deleted the ubi-golang branch January 7, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants