Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: ethers-rs version not updated to 2.0.11 (fix #941) #942

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

leejw51crypto
Copy link
Collaborator

Solution: update to ethers 2.0.11

@leejw51crypto
Copy link
Collaborator Author

checking wasm

@leejw51crypto leejw51crypto marked this pull request as draft November 28, 2023 15:02
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c4eb3ca) 42.88% compared to head (f9f4aa0) 43.08%.

Files Patch % Lines
common/src/node/ethereum/utils.rs 0.00% 5 Missing ⚠️
bindings/cpp/src/ethereum.rs 0.00% 4 Missing ⚠️
bindings/cpp/src/uint.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
+ Coverage   42.88%   43.08%   +0.20%     
==========================================
  Files          46       46              
  Lines        9176     9219      +43     
==========================================
+ Hits         3935     3972      +37     
- Misses       5241     5247       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leejw51crypto
Copy link
Collaborator Author

it's wasm related issue, reproduced error, fixing now

@leejw51crypto leejw51crypto marked this pull request as ready for review November 29, 2023 13:46
compiles

refactor

simpler

remove unwrap

remove unwrap

remove unwrap

fix wasm compile

fix fmt

fix binding

use firefox

replace delay with task::sleep
@leejw51crypto leejw51crypto added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit 52e6c5b Nov 30, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants