cleanup

crypto-org-chain · Aug 27, 2024 · fc99c9c · fc99c9c
1 parent 5932f07
commit fc99c9c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/types/mempool/priority_nonce.go b/types/mempool/priority_nonce.go
@@ -394,10 +394,7 @@ func (mp *PriorityNonceMempool[C]) SelectBy(_ context.Context, _ [][]byte, callb
 	}
 
 	iter := iterator.iteratePriority()
-	for iter != nil {
-		if !callback(iter.Tx()) {
-			break
-		}
+	for iter != nil && callback(iter.Tx()) {
 		iter = iter.Next()
 	}
 }

diff --git a/types/mempool/priority_nonce_test.go b/types/mempool/priority_nonce_test.go
@@ -474,6 +474,7 @@ func (s *MempoolTestSuite) TestIteratorConcurrency() {
 				}
 				return i < len(tt.txs)
 			})
+			require.Equal(t, i, len(tt.txs))
 			cancel()
 			wg.Wait()
 		})

diff --git a/types/mempool/sender_nonce.go b/types/mempool/sender_nonce.go
@@ -227,10 +227,7 @@ func (snm *SenderNonceMempool) SelectBy(_ context.Context, _ [][]byte, callback
 	}
 
 	iter := iterator.Next()
-	for iter != nil {
-		if !callback(iter.Tx()) {
-			break
-		}
+	for iter != nil && callback(iter.Tx()) {
 		iter = iter.Next()
 	}
 }