Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: MultiStore interface is bloated #240

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 29, 2024

Solution:

  • Split out specialied methods from it, keeping the MultiStore generic

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@yihuang yihuang requested a review from mmsqe March 29, 2024 07:33
store/CHANGELOG.md Outdated Show resolved Hide resolved
Solution:
- Split out specialied methods from it, keeping the MultiStore generic

Update store/CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang enabled auto-merge (squash) March 29, 2024 07:51
@yihuang yihuang merged commit 5051618 into crypto-org-chain:release/v0.50.x Mar 29, 2024
43 of 45 checks passed
@yihuang yihuang deleted the remove-tracing branch March 29, 2024 08:12
zsystm pushed a commit to b-harvest/cosmos-sdk that referenced this pull request May 24, 2024
…in#240)

Reason for Cherry-pick:
- Code maintainability

Original Commit Message:

* Problem: MultiStore interface is bloated

Solution:
- Split out specialied methods from it, keeping the MultiStore generic

* Update store/CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

---------

Cherry-picked-by: zsystm <actor93kor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants