Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: no api to convert native events to logs #343

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Problem: no api to convert native events to logs #343

merged 3 commits into from
Sep 12, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 12, 2023

Solution:

  • add event converters

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang
Problem: no api to convert native events to logs
46ad912 
Solution:
- add event converters
@yihuang yihuang requested a review from mmsqe September 12, 2023 03:43
mmsqe
mmsqe reviewed Sep 12, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mmsqe
Update CHANGELOG.md
398b136 
Signed-off-by: mmsqe <mavis@crypto.com>
@yihuang yihuang merged commit 81c398f into crypto-org-chain:develop Sep 12, 2023
25 of 27 checks passed
@yihuang yihuang deleted the event-conversion branch September 12, 2023 04:34
dongsam added a commit to b-harvest/ethermint that referenced this pull request Jun 4, 2024
@dongsam
feat!: add stateful precompiled contract (cherry-pick)
808bb60 
- (evm) crypto-org-chain#328 Support precompile interface.
- (statedb) crypto-org-chain#333 Support native action in statedb, prepare for precompiles.
- (precompile) crypto-org-chain#338 Fix simulation of precompile using context.
- (precompile) crypto-org-chain#342 Problem: native action don't support mem keys
- (precompile) crypto-org-chain#343 Problem: no api to convert native events to logs
- (precompile) crypto-org-chain#344 Fix error handling in precompile context.
- (precompile) crypto-org-chain#346 Add support for new precompile context.
- (precompile) crypto-org-chain#347 Problem: miss contract in ExtStateDB interface
- (precompile) crypto-org-chain#359 Problem: no efficient way to execute read-only native actions
- (precompile) crypto-org-chain#371 Add StateDB itself into native context for precompiles to emit evm logs directly.
- (precompile) crypto-org-chain#380 Allow init precompiled contract with rules when new evm.
@dongsam dongsam mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmsqe mmsqe mmsqe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @mmsqe