Problem: missing assign statedb to ctx #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsqe
commented
Nov 1, 2023
Signed-off-by: mmsqe <mavis@crypto.com>
yihuang
reviewed
Nov 1, 2023
| @@ -354,7 +354,7 @@ func (k *Keeper) ApplyMessageWithConfig(ctx sdk.Context, | |||
| return nil, errorsmod.Wrap(err, "failed to apply state override") | |||
| } | |||
| } | |||
|
|
|||
| ctx = ctx.WithValue(statedb.StateDBContextKey, stateDB) | |||
There was a problem hiding this comment.
It's already done in state db constructor.
There was a problem hiding this comment.
seems still have issue, we can't modify ctx outside
There was a problem hiding this comment.
we can't get stateDb ctx without using relayer precompile?
There was a problem hiding this comment.
no, crypto-org-chain/cronos#1233 don't need to change relayer precompile.
There was a problem hiding this comment.
no, crypto-org-chain/cronos#1233 don't need to change relayer precompile.
There was a problem hiding this comment.
no log without using relayer precompile config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)