Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: go-ethereum v1.14.x change is not included #438

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Mar 27, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 67.27273% with 18 lines in your changes missing coverage. Please review.

Project coverage is 60.01%. Comparing base (9755333) to head (c2e465e).

Files with missing lines Patch % Lines
x/evm/keeper/grpc_query.go 38.46% 6 Missing and 2 partials ⚠️
x/evm/statedb/statedb.go 72.00% 7 Missing ⚠️
rpc/backend/sign_tx.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #438      +/-   ##
===========================================
- Coverage    60.08%   60.01%   -0.08%     
===========================================
  Files          128      128              
  Lines         9844     9869      +25     
===========================================
+ Hits          5915     5923       +8     
- Misses        3345     3359      +14     
- Partials       584      587       +3     
Files with missing lines Coverage Δ
app/ante/eth.go 79.54% <100.00%> (+0.15%) ⬆️
app/ante/handler_options.go 61.53% <100.00%> (ø)
x/evm/keeper/state_transition.go 73.00% <100.00%> (+0.13%) ⬆️
x/evm/keeper/statedb.go 83.78% <100.00%> (ø)
x/evm/statedb/journal.go 94.93% <100.00%> (ø)
x/evm/statedb/state_object.go 98.13% <100.00%> (ø)
rpc/backend/sign_tx.go 57.69% <40.00%> (-1.77%) ⬇️
x/evm/statedb/statedb.go 77.18% <72.00%> (-1.34%) ⬇️
x/evm/keeper/grpc_query.go 76.85% <38.46%> (-1.30%) ⬇️

@mmsqe mmsqe changed the title Problem: go-ethereum v1.12.x change is not included Problem: go-ethereum v1.14.x change is not included Sep 25, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/aiohappyeyeballs@2.4.0 network 0 81.2 kB bdraco
pypi/aiohttp@3.10.6 None 0 0 B
pypi/annotated-types@0.7.0 None 0 64.1 kB Zac-HD, adriangb
pypi/ckzg@2.0.1 environment, eval, filesystem, shell, unsafe 0 4.93 MB jtraglia
pypi/eth-abi@5.1.0 environment, filesystem 0 235 kB carver, fselmo, kclowes, ...2 more
pypi/eth-keyfile@0.8.1 environment, filesystem 0 49.8 kB carver, kclowes, pacrob, ...1 more
pypi/eth-keys@0.5.1 environment, filesystem 0 116 kB carver, kclowes, pacrob, ...1 more
pypi/eth-rlp@2.1.0 filesystem Transitive: environment, eval, network, shell, unsafe +146 1.24 GB carver, fselmo, kclowes, ...2 more
pypi/eth-typing@5.0.0 filesystem 0 60.8 kB carver, cburgdorf, fselmo, ...5 more
pypi/eth-utils@5.0.0 environment, eval, filesystem, network, shell, unsafe 0 633 kB carver, cburgdorf, fselmo, ...5 more
pypi/hexbytes@1.2.1 filesystem 0 24.3 kB carver, fselmo, kclowes, ...2 more
pypi/multidict@6.1.0 None 0 0 B
pypi/parsimonious@0.10.0 eval, filesystem 0 190 kB erikrose, lonnen, lucaswiman
pypi/pydantic-core@2.18.4 environment, eval, filesystem, shell, unsafe 0 7.71 MB samuelcolvin
pypi/pydantic-core@2.23.4 None 0 0 B
pypi/pydantic@2.7.4 environment, eval, filesystem, shell, unsafe 0 3.83 MB samuelcolvin
pypi/pydantic@2.9.2 None 0 0 B
pypi/pyunormalize@16.0.0 eval, filesystem 0 290 kB mlodewijck
pypi/regex@2024.9.11 None 0 0 B
pypi/rlp@4.0.1 eval, filesystem, unsafe 0 134 kB carver, cburgdorf, kclowes, ...3 more
pypi/yarl@1.12.1 None 0 0 B

🚮 Removed packages: pypi/aiohttp@3.9.3, pypi/eth-abi@5.0.0, pypi/eth-account@0.11.0, pypi/eth-keyfile@0.7.0, pypi/eth-keys@0.5.0, pypi/eth-rlp@1.0.1, pypi/eth-typing@4.0.0, pypi/eth-utils@3.0.0, pypi/hexbytes@0.3.1, pypi/lru-dict@1.2.0, pypi/multidict@6.0.5, pypi/parsimonious@0.9.0, pypi/pyunormalize@15.1.0, pypi/regex@2023.12.25, pypi/rlp@4.0.0, pypi/web3@6.15.1, pypi/yarl@1.9.4

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant