Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: nondeterministic account set occurs with more stm workers #510

Closed
wants to merge 2 commits into from

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Aug 5, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe force-pushed the mismatch_ci branch 4 times, most recently from 3872111 to a85d5e3 Compare August 5, 2024 03:59
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.54%. Comparing base (0e0baa4) to head (7f124a1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #510   +/-   ##
========================================
  Coverage    61.54%   61.54%           
========================================
  Files          128      128           
  Lines         9503     9503           
========================================
  Hits          5849     5849           
  Misses        3113     3113           
  Partials       541      541           

@mmsqe mmsqe closed this Aug 6, 2024
@yihuang yihuang deleted the mismatch_ci branch August 6, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant