Problem: not allowed specify nonce when estimate gas #512
Conversation
| if args.Nonce == nil { | ||
| // ApplyMessageWithConfig expect correct nonce set in msg if not specify in request | ||
| nonce := k.GetNonce(ctx, args.GetFrom()) | ||
| args.Nonce = (*hexutil.Uint64)(&nonce) |
There was a problem hiding this comment.
hermes bump up nonce when call estimate
There was a problem hiding this comment.
isn't the nonce returned by k.GetNonce is most correct?
There was a problem hiding this comment.
nonce could be the same from k.GetNonce when estimate batches, 2nd batch call before 1st batch finalize.
There was a problem hiding this comment.
is it possible to describe the test case in integration test outside of the ibc context, still confused what are you trying to do.
There was a problem hiding this comment.
just make it easier for me to compare between client and server, otherwise I need compare with data field ;D
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #512 +/- ##
========================================
Coverage 61.54% 61.55%
========================================
Files 128 128
Lines 9503 9504 +1
========================================
+ Hits 5849 5850 +1
Misses 3113 3113
Partials 541 541
|
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)