Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: tx is not replaced by priority #519

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 2, 2024

Solution:

  • Add TxReplacement callback

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Solution:
- Add TxReplacement callback
@yihuang yihuang requested a review from mmsqe September 2, 2024 03:38
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.55%. Comparing base (fe3f4fd) to head (e195207).

Files with missing lines Patch % Lines
app/app.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #519      +/-   ##
===========================================
- Coverage    61.57%   61.55%   -0.03%     
===========================================
  Files          128      128              
  Lines         9512     9514       +2     
===========================================
- Hits          5857     5856       -1     
- Misses        3115     3117       +2     
- Partials       540      541       +1     
Files with missing lines Coverage Δ
app/app.go 75.92% <0.00%> (-0.45%) ⬇️

@yihuang yihuang marked this pull request as draft September 4, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant