Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: block-stm tx executor bad worst case performance #522

Merged
merged 13 commits into from
Sep 11, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 11, 2024

Solution:

  • Optionally do pre-estimations on the keys touched by the tx.

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang marked this pull request as ready for review September 11, 2024 08:50
@yihuang yihuang requested a review from mmsqe September 11, 2024 08:50
@yihuang yihuang changed the title Problem: block-stm tx executor don't do simple static dependency Problem: block-stm tx executor bad worst case performance Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 7.81250% with 59 lines in your changes missing coverage. Please review.

Project coverage is 60.24%. Comparing base (3fabdbe) to head (98721c2).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
app/executor.go 2.08% 47 Missing ⚠️
app/app.go 36.36% 7 Missing ⚠️
server/config/config.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #522      +/-   ##
===========================================
- Coverage    60.50%   60.24%   -0.26%     
===========================================
  Files          128      128              
  Lines         9757     9800      +43     
===========================================
+ Hits          5903     5904       +1     
- Misses        3273     3315      +42     
  Partials       581      581              
Files with missing lines Coverage Δ
server/config/config.go 35.22% <0.00%> (-0.23%) ⬇️
app/app.go 76.24% <36.36%> (-0.14%) ⬇️
app/executor.go 3.73% <2.08%> (-0.81%) ⬇️

@yihuang yihuang enabled auto-merge (squash) September 11, 2024 09:17
@yihuang yihuang merged commit 79bb39e into crypto-org-chain:develop Sep 11, 2024
37 of 39 checks passed
@yihuang yihuang deleted the dep-analysis branch September 11, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants