Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: pre-estimation don't run in parallel #523

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 12, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

app/executor.go Fixed Show fixed Hide fixed
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 60.11%. Comparing base (79bb39e) to head (6629d4e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
app/executor.go 0.00% 53 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #523      +/-   ##
===========================================
- Coverage    60.24%   60.11%   -0.13%     
===========================================
  Files          128      128              
  Lines         9800     9821      +21     
===========================================
  Hits          5904     5904              
- Misses        3315     3336      +21     
  Partials       581      581              
Files with missing lines Coverage Δ
app/executor.go 3.12% <0.00%> (-0.62%) ⬇️

@yihuang yihuang marked this pull request as ready for review September 12, 2024 03:57
@yihuang yihuang requested a review from mmsqe September 12, 2024 03:57
Comment on lines +248 to +251
go func() {
defer wg.Done()
job(start, end)
}()

Check notice

Code scanning / CodeQL

Spawning a Go routine Note

Spawning a Go routine may be a possible source of non-determinism
@yihuang yihuang enabled auto-merge (squash) September 12, 2024 04:15
app/executor.go Show resolved Hide resolved
app/executor.go Show resolved Hide resolved
@yihuang yihuang merged commit 56f8a5b into crypto-org-chain:develop Sep 12, 2024
36 of 38 checks passed
@yihuang yihuang deleted the dep-analysis branch September 12, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants