Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: trace block gas refund change not committed #527

Merged
merged 7 commits into from
Sep 24, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 23, 2024

Description

change to work on SDK context directly.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang marked this pull request as draft September 23, 2024 08:10
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 60.08%. Comparing base (7e30762) to head (14733dd).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/keeper/state_transition.go 75.00% 3 Missing and 2 partials ⚠️
x/evm/keeper/statedb.go 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #527      +/-   ##
===========================================
+ Coverage    60.06%   60.08%   +0.02%     
===========================================
  Files          128      128              
  Lines         9829     9844      +15     
===========================================
+ Hits          5904     5915      +11     
- Misses        3343     3345       +2     
- Partials       582      584       +2     
Files with missing lines Coverage Δ
x/evm/keeper/config.go 91.54% <100.00%> (+0.24%) ⬆️
x/evm/keeper/statedb.go 83.78% <50.00%> (-2.63%) ⬇️
x/evm/keeper/state_transition.go 72.86% <75.00%> (-0.34%) ⬇️

... and 1 file with indirect coverage changes

@yihuang yihuang changed the title Problem: trace block not accurate for dynamic fee transaction Problem: trace block gas refund change not committed Sep 23, 2024
@yihuang yihuang marked this pull request as ready for review September 23, 2024 08:55
@yihuang yihuang merged commit bcac9e2 into crypto-org-chain:develop Sep 24, 2024
38 of 39 checks passed
@yihuang yihuang deleted the develop branch September 24, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants