Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graceful shutdown of websocket #547

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

valli0x
Copy link

@valli0x valli0x commented Oct 25, 2024

checking for ctx.Done in a websockets subscription. It needed for graceful shutdown.

rpc/websockets.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 46.16%. Comparing base (e567c5a) to head (852b2d9).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
rpc/websockets.go 0.00% 12 Missing ⚠️
server/json_rpc.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #547      +/-   ##
===========================================
- Coverage    46.17%   46.16%   -0.01%     
===========================================
  Files          181      181              
  Lines        18122    18125       +3     
===========================================
  Hits          8368     8368              
- Misses        9037     9040       +3     
  Partials       717      717              
Files with missing lines Coverage Δ
server/json_rpc.go 0.00% <0.00%> (ø)
rpc/websockets.go 0.00% <0.00%> (ø)

@mmsqe mmsqe enabled auto-merge (squash) October 29, 2024 01:33
@mmsqe mmsqe merged commit ce5773e into crypto-org-chain:develop Oct 30, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants