Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: state overwrite not work in debug trace API (backport: #545) #553

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Nov 4, 2024

  • Problem: state overwrite not work in debug trace API

  • test

  • fix

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* Problem: state overwrite not work in debug trace API

* test

* fix
@mmsqe mmsqe requested a review from yihuang November 4, 2024 04:44
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.16%. Comparing base (36adc9c) to head (bb8f9c2).
Report is 1 commits behind head on release/v0.22.x-cronos.

Files with missing lines Patch % Lines
x/evm/keeper/state_transition.go 53.84% 4 Missing and 2 partials ⚠️
x/evm/statedb/statedb.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.22.x-cronos     #553      +/-   ##
==========================================================
- Coverage                   64.02%   63.16%   -0.87%     
==========================================================
  Files                         130      130              
  Lines                        9790    12367    +2577     
==========================================================
+ Hits                         6268     7811    +1543     
- Misses                       3006     4043    +1037     
+ Partials                      516      513       -3     
Files with missing lines Coverage Δ
x/evm/keeper/statedb.go 86.40% <ø> (+0.94%) ⬆️
x/evm/statedb/statedb.go 81.32% <0.00%> (-1.08%) ⬇️
x/evm/keeper/state_transition.go 73.63% <53.84%> (-2.76%) ⬇️

... and 121 files with indirect coverage changes

@mmsqe mmsqe merged commit 1e621c7 into crypto-org-chain:release/v0.22.x-cronos Nov 4, 2024
27 of 31 checks passed
@yihuang yihuang deleted the release/v0.22.x-cronos_trace branch November 4, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants