Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wallet load error on incomplete gettransaction (Failed to load utxos, IndexError: list index out of range) #2467

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix wallet load error on incomplete gettransaction (Failed to load utxos, IndexError: list index out of range) #2467

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d74d4ab
Fix wallet load error on incomplete gettransaction
leon-costa Jul 4, 2024
ec5e1b2
Apply black formatting
leon-costa Aug 1, 2024
2efd56c
Use embit to decode the raw transaction
leon-costa Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/cryptoadvance/specter/wallet/wallet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,13 +718,24 @@ def check_utxo(self):
else:
tx_from_core = self.rpc.gettransaction(tx_copy["txid"])
# in the case of locked amounts, the stupid listlockunspent call does not contain reasonable utxo-data
searched_vout = [
searched_vouts = [
_tx
for _tx in tx_from_core["details"]
if _tx["vout"] == utxo_vout
][0]
tx_copy["amount"] = searched_vout["amount"]
tx_copy["address"] = searched_vout["address"]
]
if len(searched_vouts) > 0:
searched_vout = searched_vouts[0]
tx_copy["amount"] = searched_vout["amount"]
tx_copy["address"] = searched_vout["address"]
else:
# Sometimes gettransaction doesn't return the complete list of outputs.
# It may be related to https://github.com/bitcoin/bitcoin/issues/28555
# In this case we decode the raw transaction to get the data we want.
raw_transaction_hex = tx_from_core["hex"]
parsed_transaction = self.TxCls.from_string(raw_transaction_hex)
out = parsed_transaction.vout[utxo_vout]
tx_copy["amount"] = round(out.value * 1e-8, 8)
tx_copy["address"] = out.script_pubkey.address(self.network)

# Append the copy to the _full_utxo list
_full_utxo.append(tx_copy)
Expand Down
Loading