More efficient butterfly in inverse NTT layers 0-2 #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 14, 2024
franziskuskiefer
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Thanks, let's get this in.
The main slow down is from #646 not propagating inlines for the hashing. Simply adding them back gets us into trouble with the stack again, but back to what I've seen after my changes the last time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the optimization of batching two butterflies in AVX2 for layers 0 through 2 of the inverse NTT, as is already done on the forward NTT.
I've also pushed all of the inverse NTT into the respective instantiation modules with the hope of improving optimizations done by the compiler.