Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant match arms #739

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Remove redundant match arms #739

merged 2 commits into from
Jan 14, 2025

Conversation

jschneider-bensch
Copy link
Collaborator

No description provided.

@jschneider-bensch jschneider-bensch mentioned this pull request Jan 14, 2025
Merged
franziskuskiefer
franziskuskiefer reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looking at the entire function again I'm not sure why this is here and we should remove it. I see mlkem variants further up, so a not(kyber) config doesn't seem what we want either.

@jschneider-bensch jschneider-bensch marked this pull request as ready for review January 14, 2025 09:07
@jschneider-bensch jschneider-bensch requested a review from a team as a code owner January 14, 2025 09:07
@franziskuskiefer franziskuskiefer added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 506666a Jan 14, 2025
57 checks passed
@franziskuskiefer franziskuskiefer deleted the jonas/kyber-redundancy branch January 14, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees

@jschneider-bensch jschneider-bensch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschneider-bensch @franziskuskiefer