New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: interview revision #8

Merged

csatib02 merged 1 commit into main from fix/interview-review

Sep 14, 2024

Owner

csatib02 commented Sep 8, 2024 •

edited

Loading

This PR changes some problems outlined at the interview :

When utilising a log server, the user should be able to decide what transport protocol is being used.
The ListResource function in the k8s package, mistakenly used the type created for concrete resourceType subjects. It has been changed to use the enum type: ResourceType instead.
Enhanced the makefile to enforce using the dependency versions specified within.

csatib02 self-assigned this

csatib02 force-pushed the fix/interview-review branch 5 times, most recently from 882b492 to 0c098a7 Compare

September 8, 2024 15:45


          fix: interview revision

1907c02

Signed-off-by: Bence Csati <csatib02@gmail.com>

csatib02 force-pushed the fix/interview-review branch from 0c098a7 to 1907c02 Compare

September 8, 2024 15:49

csatib02 merged commit 29a52d5 into main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet