Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scroll input on non-windows #43

Merged
merged 5 commits into from
Jan 8, 2025
Merged

scroll input on non-windows #43

merged 5 commits into from
Jan 8, 2025

Conversation

JeromeSchmied
Copy link
Collaborator

@JeromeSchmied JeromeSchmied commented Dec 17, 2024 •
edited
Loading

description

add support for scroll input for non-windows operating-systems
fixes #42

Changelog

  • fix(input): recognize scroll on unix-like systems as well
  • refactor(input): seems like set_non_blocking is unnecessary
  • refactor(input): simplify code
  • refactor(input): simplify code
  • docs: updated

@JeromeSchmied JeromeSchmied changed the title scroll input unix like scroll input on non-windos Dec 17, 2024
@JeromeSchmied JeromeSchmied self-assigned this Dec 17, 2024
@JeromeSchmied JeromeSchmied marked this pull request as ready for review December 17, 2024 12:34
@JeromeSchmied JeromeSchmied changed the title scroll input on non-windos scroll input on non-windows Dec 21, 2024
@csboo csboo merged commit c4854bd into main Jan 8, 2025
5 checks passed
@csboo csboo deleted the scroll-input-unix-like branch January 8, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csboo csboo csboo approved these changes

Assignees

@JeromeSchmied JeromeSchmied

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mouse/touchpad scroll
2 participants
@JeromeSchmied @csboo