Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate breached passwords script #14

Merged
merged 46 commits into from
Oct 24, 2023
Merged

Generate breached passwords script #14

merged 46 commits into from
Oct 24, 2023

Conversation

ni-jessica
Copy link
Collaborator

No description provided.

@ni-jessica ni-jessica linked an issue Oct 15, 2023 that may be closed by this pull request
Create breached password generator script #7
Closed
stellaljung
stellaljung reviewed Oct 16, 2023
View reviewed changes
backend/database/generatePasswords.py Outdated Show resolved Hide resolved
backend/database/generatePasswords.py Outdated Show resolved Hide resolved
backend/database/generatePasswords.py Outdated Show resolved Hide resolved
backend/database/generatePasswords.py Outdated Show resolved Hide resolved
csirianni
csirianni requested changes Oct 18, 2023
View reviewed changes
Copy link
Owner

@csirianni csirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make this more exhaustive of user passwords in the future if we want. Maybe by including a string or enum for the type of passwords to generate. But I don't think it impacts the functionality of the system, so it's fine either way.

backend/database/generatePasswords.py Outdated Show resolved Hide resolved
backend/database/generatePasswords.py Outdated Show resolved Hide resolved
backend/database/generatePasswords.py Outdated Show resolved Hide resolved
backend/database/generatePasswords.py Outdated Show resolved Hide resolved
backend/database/generatePasswords.py Outdated Show resolved Hide resolved
backend/database/generatePasswords.py Outdated Show resolved Hide resolved
csirianni
csirianni reviewed Oct 22, 2023
View reviewed changes
Copy link
Owner

@csirianni csirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this. Lots of small details to address, but most of it is not correctness/program logic related. I'll look into the CMakeLists.txt stuff soon.

backend/src/main.cpp Outdated Show resolved Hide resolved
backend/src/passwords.cpp Outdated Show resolved Hide resolved
backend/src/passwords.cpp Outdated Show resolved Hide resolved
backend/src/passwords.cpp Outdated Show resolved Hide resolved
backend/src/passwords.cpp Outdated Show resolved Hide resolved
backend/src/passwords.cpp Outdated Show resolved Hide resolved
backend/tests/test.cpp Outdated Show resolved Hide resolved
backend/README.md Show resolved Hide resolved
backend/CMakeLists.txt Outdated Show resolved Hide resolved
backend/CMakeLists.txt Outdated Show resolved Hide resolved
stellaljung
stellaljung reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@stellaljung stellaljung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: I will help today to refactor based on Cedric's comments, but I reviewed the code and it looks good except for minor c++ details.

stellaljung
stellaljung previously approved these changes Oct 23, 2023
View reviewed changes
ni-jessica
ni-jessica commented Oct 24, 2023
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
backend/src/main.cpp Outdated Show resolved Hide resolved
backend/src/password.cpp Show resolved Hide resolved
@csirianni
feat: add exception handling
623c50b
@csirianni
test: check exception is thrown
9901f6c
@csirianni
build: use multiple CMakeLists.txt files
b381531
@csirianni
build: use correct library and executable names
4ddc6ca
@csirianni
refactor: rename tests folder to test
015335e
@csirianni
refactor: rename password test file
07beb40
@csirianni
refactor: use member naming convention
0aeb3df
@csirianni
docs: follow markdown convention
95d7f6e
@csirianni
refactor: use anonymous namespace for helper functions
ddb990a
@csirianni
build: use src as library name
809007e
@csirianni
build: add Makefile
7bdf526
@csirianni
ci: add backend build and test to pipeline
efead70
@csirianni
ci: use conan profile detect
78d425b
@csirianni
ci: remove conan profile update
302714c
@csirianni
ci: fix build commands
12fa8b8
@csirianni
ci: use correct paths
bbf313a
@csirianni
ci: use correct flag
c5204ba
@csirianni
ci: call cmake from correct location
f4c2064
@csirianni
ci: put correct location on the right step
9f96017
@csirianni
ci: use correct relative path
b95d945
@csirianni
ci: use correct relative path in test job
fff94f3
@csirianni
ci: combine build and test jobs
d5f7360
@csirianni
docs: add badge to README
3ac850f
@csirianni
feat: add proper error handling to close()
2187b17
@csirianni
ci: remove on pull_request from commits.yml
e526754
@csirianni
docs: put badge on same line
d6a09ad
@csirianni csirianni merged commit dbbe895 into main Oct 24, 2023
3 checks passed
@csirianni csirianni deleted the 7-create-breached-password-generator-script branch October 24, 2023 21:29
@csirianni csirianni changed the title feat: generate breached passwords script Generate breached passwords script Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csirianni csirianni csirianni approved these changes

@stellaljung stellaljung stellaljung left review comments

Assignees

@stellaljung stellaljung

@ni-jessica ni-jessica

Labels
enhancement New feature or request
Projects
PDL Kanban
Status: Done
Milestone
Sprint 0
Development

Successfully merging this pull request may close these issues.

Create breached password generator script
3 participants
@ni-jessica @csirianni @stellaljung