Refactor: {{action}} helper usage
#635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of ModelSaveUtils
… how to do this, and it should not have taken this long lol.
…oller, and they are now all in octane style! :)
…ting late, so I will continue this some other time.
…factoring templates to use the new action
…at call the cancel action from one of the Created, Edit, Destroy Controllers
…hod to the madness lol
…osts in a paged fashion everytime the queryparams change
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #635 +/- ##
===========================================
- Coverage 13.79% 13.63% -0.17%
===========================================
Files 450 450
Lines 3067 3081 +14
===========================================
- Hits 423 420 -3
- Misses 2644 2661 +17 ☔ View full report in Codecov by Sentry. |
|
I'm going to ignore the quickpost related files because of #889 |
|
still 137 "action " occurrences to go, at least in hbs files: |
|
@lodewiges this PR is getting rather big, so I think I will mark this one ready for review soon, and then work further in another PR. By merging separate PRs, we are less likely to significantly disrupt production |
2 tasks
DrumsnChocolate
changed the title
{{action}} helper usage
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://guides.emberjs.com/release/upgrading/current-edition/action-on-and-fn/
base branch will be updated ✨ automatically ✨ when #556 merges into staging
ref #899
this is not the whole thing, I am opening a sequel PR soon. For the sake of keeping PRs reviewable.
How to review this: