-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix notebooks not executable in CI #1295
Comments
thanks for the effort @vuillaut |
Both calculate_sensitivity_from_Crab and data_quality work, but need as input very long samples to produce meaningful output. I think it is not feasible to have such samples in the standard test data. The first of the two also takes very long to finish. What can one do in such cases? |
No, we've just got a few hundred raw-data events. However, we could think of actually including these 1h-data DL2 files trimming the parameters not needed for the theta2 calculation from DL2 files. For the other two notebooks, it's hard to say. Actually, the data quality notebook could be transformed into a script, that could be more easily tested. Although the notebook give you the interactive part, that is also helpful. I think it is enough for these three notebooks that they can run and are up to date (in this case checked manually) |
This is a continuation of #1091
I propose that all authors go through their notebook and see:
Here is a list of all notebooks and their original author.
Please open a PR to fix your notebooks and check the boxes here.
The text was updated successfully, but these errors were encountered: