Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebooks not executable in CI #1295

Open
2 of 31 tasks
vuillaut opened this issue Sep 24, 2024 · 3 comments
Open
2 of 31 tasks

Fix notebooks not executable in CI #1295

vuillaut opened this issue Sep 24, 2024 · 3 comments

Comments

@vuillaut
Copy link
Member

vuillaut commented Sep 24, 2024

This is a continuation of #1091

I propose that all authors go through their notebook and see:

  • if it can run - and if not update it
  • if it can run with the test data available in the CI rather than a custom path
  • delete it if completely obsolete

Here is a list of all notebooks and their original author.
Please open a PR to fix your notebooks and check the boxes here.

@morcuended
Copy link
Member

thanks for the effort @vuillaut

@moralejo
Copy link
Collaborator

moralejo commented Sep 25, 2024

Both calculate_sensitivity_from_Crab and data_quality work, but need as input very long samples to produce meaningful output. I think it is not feasible to have such samples in the standard test data. The first of the two also takes very long to finish. What can one do in such cases?
As for explore_DL2, it could do with O(1h) of Crab, but I do not think we have such a DL2 sample in the test data, right?

@morcuended
Copy link
Member

As for explore_DL2, it could do with O(1h) of Crab, but I do not think we have such a DL2 sample in the test data, right?

No, we've just got a few hundred raw-data events. However, we could think of actually including these 1h-data DL2 files trimming the parameters not needed for the theta2 calculation from DL2 files.

For the other two notebooks, it's hard to say. Actually, the data quality notebook could be transformed into a script, that could be more easily tested. Although the notebook give you the interactive part, that is also helpful.
Concerning the sensitivity one, I agree it'd be hard to include it in the CI and use test data. But it'd be great if somehow this could be checked automatically for every (major) lstchain release and compare it with sensitivity calculated with previous version. But it goes beyond the scope of this PR.

I think it is enough for these three notebooks that they can run and are up to date (in this case checked manually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants