-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for scaling true energy in IRFs to assess energy-scale systematics #1261
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
+ Coverage 73.28% 73.35% +0.07%
==========================================
Files 134 134
Lines 14084 14117 +33
==========================================
+ Hits 10321 10356 +35
+ Misses 3763 3761 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @deborahDOR, it looks good to me, I just left some comments regarding the description of the new energy scaling factor. Maybe also try to add a small unit test for this (?)
Upload of the modifications suggested.
Add alias and header for 'scale_true_energy' component.
Example code in the IRF tool.
Add a test for verification of the validation of modified IRFs Need to be refined because only few events.
Change the directories for config files.
Update new test for energy sclaing in IRFs which has been verified and adapted.
Use only one config_file for the test for energy scaling in irfs
Remove --point-like argument
Remove additional comments.
Cleaning of code for assert lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @deborahDOR and @chaimain
Use only one config_file for the test for energy scaling in irfs
Modifications of the code for the consideration of systematics in the energy.
The goal is to generate modified IRFs due to the effect of a lower or higher light efficiency in the system (telescope + atmosphere) with respect to simulations, by scaling the true energy values in MC simulations.
The changes are: