Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waveform noise tuner #1282

Merged
merged 21 commits into from
Aug 1, 2024
Merged

Waveform noise tuner #1282

merged 21 commits into from
Aug 1, 2024
+272 −146

Commits on Jul 31, 2024

  1. New version of the code to obtain the NSB tuning parameters

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    91cdd0b View commit details
    Browse the repository at this point in the history

  2. Adapted all calls of WaveformNsbTunner to new arguments

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    99a2d9d View commit details
    Browse the repository at this point in the history

  3. Solved a number of issues (wrong variable names etc)

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    bf27816 View commit details
    Browse the repository at this point in the history

  4. Fix logger string. Remove unused import.

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b7237a6 View commit details
    Browse the repository at this point in the history

  5. Fixed wrong averaging axis

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    7a2a686 View commit details
    Browse the repository at this point in the history

  6. Wrong indent!

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b3f07d1 View commit details
    Browse the repository at this point in the history

  7. Replaced array by dict in arguments

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    cbbaaa5 View commit details
    Browse the repository at this point in the history

  8. Small refactoring

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    0c96287 View commit details
    Browse the repository at this point in the history

  9. Removed unused variable

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    481d90c View commit details
    Browse the repository at this point in the history

  10. fix missing tel_id

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    6b7d05c View commit details
    Browse the repository at this point in the history

  11. Attempt to fix tests

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    0f75e8b View commit details
    Browse the repository at this point in the history

  12. Correct config key

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3cb7b2b View commit details
    Browse the repository at this point in the history

  13. Removed unnecesary ".keys()"

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    21d725b View commit details
    Browse the repository at this point in the history

  14. Improved comment. Made test (with slightly random result) more tolerant

    @moralejo
    moralejo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    52c8dd2 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Added comments. Don't allow extra_nsb to be <0

    @moralejo
    moralejo committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    38590fc View commit details
    Browse the repository at this point in the history

  2. Fixed test

    @moralejo
    moralejo committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    e5c2446 View commit details
    Browse the repository at this point in the history

  3. Update lstchain/image/modifier.py 

    Co-authored-by: Daniel Morcuende <dmorcuende@iaa.es>
    @moralejo @morcuended
    moralejo and morcuended authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    db0bdf7 View commit details
    Browse the repository at this point in the history

  4. Update lstchain/image/modifier.py 

    Co-authored-by: Daniel Morcuende <dmorcuende@iaa.es>
    @moralejo @morcuended
    moralejo and morcuended authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    15f6f58 View commit details
    Browse the repository at this point in the history

  5. Use max() for more readable code 

    Co-authored-by: Daniel Morcuende <dmorcuende@iaa.es>
    @moralejo @morcuended
    moralejo and morcuended authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    933df16 View commit details
    Browse the repository at this point in the history

  6. Typo 

    Co-authored-by: Daniel Morcuende <dmorcuende@iaa.es>
    @moralejo @morcuended
    moralejo and morcuended authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    fbd2c19 View commit details
    Browse the repository at this point in the history

  7. WaveformNsbTunner => WaveformNsbTuner

    @moralejo
    moralejo committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    20d04bb View commit details
    Browse the repository at this point in the history