Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace test file #1291

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Replace test file #1291

wants to merge 2 commits into from

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Sep 17, 2024

New file is not yet on the data server, but will be there tomorrow

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@morcuended
Copy link
Member

@maxnoe is the new test file already in the data server?

@maxnoe
Copy link
Member Author

maxnoe commented Oct 1, 2024

No, not yet. @kosack had some issues connecting to the server, but I think they are solved now.

But he's on vacation until the 4th

@morcuended
Copy link
Member

@maxnoe, @kosack, a friendly reminder for the replacement of the test file.

@maxnoe
Copy link
Member Author

maxnoe commented Nov 6, 2024

Test file is now there, let's see

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.50%. Comparing base (cfd9a7f) to head (310da26).

Files with missing lines Patch % Lines
lstchain/reco/r0_to_dl1.py 0.00% 1 Missing ⚠️
lstchain/scripts/lstchain_mc_r0_to_dl1.py 0.00% 1 Missing ⚠️
lstchain/scripts/lstchain_mc_r0_to_dl2.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1291   +/-   ##
=======================================
  Coverage   73.50%   73.50%           
=======================================
  Files         134      134           
  Lines       14211    14211           
=======================================
  Hits        10446    10446           
  Misses       3765     3765           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morcuended
Copy link
Member

Maybe add a test for r0 to dl1 script running without input argument to make sure it works in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants