Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to ctapipe_io_lst 0.24 #1314

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Bump to ctapipe_io_lst 0.24 #1314

merged 1 commit into from
Nov 7, 2024

Conversation

morcuended
Copy link
Member

To be compatible with the new LST calibration library, we must require ctapipe_io_lst >= 0.24.0.

From 0.23 to 0.24 there was only the addition of ctapipe 0.21 compatibility as a major change

@morcuended morcuended linked an issue Oct 28, 2024 that may be closed by this pull request
@morcuended
Copy link
Member Author

ctapipe_io_lst 0.24 is not yet available in conda forge

@rlopezcoto
Copy link
Contributor

rlopezcoto commented Nov 7, 2024

tests are not passing, probably because of this, I re-run them, let's merge whenever they are finished

@rlopezcoto
Copy link
Contributor

tests are not passing, probably because of this, I re-run them, let's merge whenever they are finished

no, there seems to be some mamba setup problem for the CI...

@maxnoe
Copy link
Member

maxnoe commented Nov 7, 2024

@rlopezcoto The problem with the mamba setup is that the package for ctapipe_io_lst is not there:

   error    libmamba Could not solve for environment specs
      The following package could not be installed
      └─ ctapipe_io_lst =0.24 does not exist (perhaps a typo or a missing channel).
  critical libmamba Could not solve for environment specs

Sorry for letting this slip. I updated the PR in the conda-forge repo, package should be available soon.

@rlopezcoto
Copy link
Contributor

Ah ok, no problem, thanks @maxnoe !

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.50%. Comparing base (cfd9a7f) to head (749dc95).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1314   +/-   ##
=======================================
  Coverage   73.50%   73.50%           
=======================================
  Files         134      134           
  Lines       14211    14211           
=======================================
  Hits        10446    10446           
  Misses       3765     3765           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rlopezcoto rlopezcoto merged commit 9bab172 into main Nov 7, 2024
9 checks passed
@rlopezcoto rlopezcoto deleted the new_version_ctapipe_io_lst branch November 7, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump ctapipe_io_lst to latest version?
4 participants