Add calibration calculators #2609
Conversation
added PlainExtractor based on numpy and scipy functions
restructured the stats containers
…ctapipe into stats_extractor
Remove StarVarianceExtractor since is functionality is featured in the existing Extractors
allow overlapping extraction sequences
renaming to chunk(s) and chunk_size and _shift added test for chunk_shift and boundary case
polish doctrings for trait help
This comment has been minimized.
This comment has been minimized.
I think (after this is merged here) we should talk about the place of these tools. I don't really see why we should add the basic components needed (only) by these tools to ctapipe itself, but then the tools only to calibpipe. |
renamed traits in the tests for the outlier detection
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
maxnoe
force-pushed
the
CalibrationCalculators
branch
from
7821e48
to
4a5f6e6
Compare
This comment has been minimized.
This comment has been minimized.
Analysis Details0 Issues
Coverage and Duplications
Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
There was a problem hiding this comment.
I think it looks good now. The only question is if you should add a template/example config file for it that can be generated by ctapipe-quickstart, as we do for other tools.
For that you would just need to create a YAML config file in ctapipe/reasources/ and modify CONFIGS_TO_WRITE in quickstart.py.
|
@kosack there is no tool here |
You're right... I was looking at the config in the test case, but that is only a Component config, and the tool is in calibpipe. Then everything is ok, and we can open an issue to add a generic tool separately. |
|
@TjarkMiener If you have no issue with it, I will squash this PR. 116 commits for these changes seems a bit much. |
|
Sure, I think the huge numbers of commits is because we branched off the stats_extractor branch back in the days, which are included. |
This PR contains the
StatisticsCalculator, which aggregates statistics, detects outliers, handles faulty data chunks. TheStatisticsCalculatorholds two functions to conduct two different passes over the data with and without overlapping chunks. The first pass is conducted with non-overlapping, while overlapping chunks can be set by thechunk_shiftparameter in the second pass. The second pass over the data is only conducted in regions of trouble with a high percentage of faulty pixels exceeding the thresholdfaulty_pixels_threshold.related to issue #2542