Hillas psi uncertainty ruo #2629
Open
+178
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sContainer Field b_uncertainty: deg (angle) and m (length) are not convertible
maxnoe
reviewed
Oct 29, 2024
src/ctapipe/containers.py
Outdated
| @@ -301,6 +301,10 @@ class CameraHillasParametersContainer(BaseHillasParametersContainer): | |||
| width = Field(nan * u.m, "standard spread along the minor-axis", unit=u.m) | |||
| width_uncertainty = Field(nan * u.m, "uncertainty of width", unit=u.m) | |||
| psi = Field(nan * u.deg, "rotation angle of ellipse", unit=u.deg) | |||
| psi_uncertainty = Field(nan * u.deg, "uncertainty of psi", unit=u.deg) | |||
| b_uncertainty = Field( | |||
There was a problem hiding this comment.
This needs a better name. Also, for what is this additional uncertainty needed?
There was a problem hiding this comment.
The axis of the image is modeled with the function y = ax + b. After rotating the image (so the axis is horizontal), the uncertainty of a = psi uncertainty. However, the axis uncertainty along the transverse direction should be the combination of the psi uncertainty and the b uncertainty, i.e. transverse uncertainty sigma_t = pow( pow(dsigma_psi,2) + pow(sigma_b,2) , 0.5), where d is the longitudinal coordinate of the test point.
There was a problem hiding this comment.
How about "transverse_cog_uncertainty" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding estimation of image psi uncertainty and uncertainty of image cog along the rotated y-axis in hillas.py.
Also adding a test script to show the validation of psi uncertainty estimation using toy models.