-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iter all events #214
base: main
Are you sure you want to change the base?
Iter all events #214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I could see this is great and should be merged.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 86.81% 86.60% -0.21%
==========================================
Files 24 24
Lines 2252 2240 -12
==========================================
- Hits 1955 1940 -15
- Misses 297 300 +3 ☔ View full report in Codecov by Sentry. |
b4b692f
to
02b8280
Compare
I tested this with ctapipe and while it seems to work nicely and we are able to write all shower information now when not skipping non-triggered events with some small changes to the SimTelEventSource the default case of skipping non-triggered events is now approximately 10 % slower. This is not great and I will see if I can get this performance drop back somehow. |
02b8280
to
e1fa532
Compare
295c4c2
to
93ba61a
Compare
Back to draft has we discovered that not all event state is cleared properly once an event as been returned (e.g. events without photo electrons "inherit" the last valid photo electron object) |
…d. Only add keys which are actually present.
Should fix #212 and #213