Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iter all events #214

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Iter all events #214

wants to merge 6 commits into from

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 9, 2020

Should fix #212 and #213

kosack
kosack previously approved these changes Oct 14, 2020
dneise
dneise previously approved these changes Oct 14, 2020
Copy link
Member

@dneise dneise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I could see this is great and should be merged.

@maxnoe maxnoe added this to the v2.0.0 milestone Feb 15, 2021
@maxnoe maxnoe dismissed stale reviews from dneise and kosack via 1e44e43 February 15, 2021 17:55
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Attention: Patch coverage is 94.84536% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 86.60%. Comparing base (87d6314) to head (ffa98ef).

Files Patch % Lines
src/eventio/simtel/simtelfile.py 94.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   86.81%   86.60%   -0.21%     
==========================================
  Files          24       24              
  Lines        2252     2240      -12     
==========================================
- Hits         1955     1940      -15     
- Misses        297      300       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe
Copy link
Member Author

maxnoe commented Nov 3, 2021

I tested this with ctapipe and while it seems to work nicely and we are able to write all shower information now when not skipping non-triggered events with some small changes to the SimTelEventSource the default case of skipping non-triggered events is now approximately 10 % slower.

This is not great and I will see if I can get this performance drop back somehow.

@maxnoe maxnoe marked this pull request as draft March 22, 2024 09:34
@maxnoe
Copy link
Member Author

maxnoe commented Mar 22, 2024

Back to draft has we discovered that not all event state is cleared properly once an event as been returned (e.g. events without photo electrons "inherit" the last valid photo electron object)

…d. Only add keys which are actually present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants