Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading of central trigger object in case of new mono trigger #262

Merged
merged 5 commits into from
Oct 15, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 12, 2023

The code made the assumption that the trigger mask is stored as a "normal" 8-bit unsigned integer instead of a variable length unsigned integer.

This assumption was always valid until now, but the new mono trigger requires correctly reading the masks as variable length integers.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (94ebedd) 86.40% compared to head (8dd2e4a) 86.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   86.40%   86.46%   +0.05%     
==========================================
  Files          24       24              
  Lines        2192     2201       +9     
==========================================
+ Hits         1894     1903       +9     
  Misses        298      298              
Files Coverage Δ
src/eventio/simtel/objects.py 81.20% <100.00%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@orelgueta orelgueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxnoe!

I cannot claim to understand every line of new code added, but what I do follow looks good and I can confirm the code works with the files I simulated (with and without mono trigger).

@maxnoe maxnoe merged commit 2da7d58 into main Oct 15, 2023
6 checks passed
@maxnoe maxnoe deleted the mono_trigger_fix branch October 15, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants