-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PixelList v1, ImageParameters v6, read LaserCalibration n_pixels as unsigned #267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Max, you forgot to commit also the new test files, so the tests fail on GitHub. The changes to the code look good though, so once the files are uploaded and tests pass, I will approve.
I am waiting for a suitable file from @lheckmann, the original file she used for the report is a bit too large to use as a test file and since it only triggers with more than 37k pixels, I wasn't yet trying myself to create one. |
I sent you one on slack that should hopefully work. Here it is as well, let me know if it works: |
@orelgueta File added and tests adapted |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 86.46% 86.54% +0.07%
==========================================
Files 24 24
Lines 2201 2214 +13
==========================================
+ Hits 1903 1916 +13
Misses 298 298
☔ View full report in Codecov by Sentry. |
No description provided.