Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PixelList v1, ImageParameters v6, read LaserCalibration n_pixels as unsigned #267

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 7, 2023

No description provided.

Copy link
Contributor

@orelgueta orelgueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Max, you forgot to commit also the new test files, so the tests fail on GitHub. The changes to the code look good though, so once the files are uploaded and tests pass, I will approve.

@maxnoe
Copy link
Member Author

maxnoe commented Nov 9, 2023

Hi Max, you forgot to commit also the new test files, so the tests fail on GitHub.

I am waiting for a suitable file from @lheckmann, the original file she used for the report is a bit too large to use as a test file and since it only triggers with more than 37k pixels, I wasn't yet trying myself to create one.

@lheckmann
Copy link

lheckmann commented Nov 9, 2023

Hi Max, you forgot to commit also the new test files, so the tests fail on GitHub.

I am waiting for a suitable file from @lheckmann, the original file she used for the report is a bit too large to use as a test file and since it only triggers with more than 37k pixels, I wasn't yet trying myself to create one.

I sent you one on slack that should hopefully work. Here it is as well, let me know if it works:
hess_raw.simtel.gz

@maxnoe
Copy link
Member Author

maxnoe commented Nov 9, 2023

@orelgueta File added and tests adapted

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (074ef89) 86.46% compared to head (7e72b61) 86.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   86.46%   86.54%   +0.07%     
==========================================
  Files          24       24              
  Lines        2201     2214      +13     
==========================================
+ Hits         1903     1916      +13     
  Misses        298      298              
Files Coverage Δ
src/eventio/simtel/objects.py 81.45% <100.00%> (+0.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe maxnoe merged commit 81be61d into main Nov 9, 2023
6 checks passed
@maxnoe maxnoe deleted the fix_n_pixels branch November 9, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants