Update setup.py / pyproject.toml to follow latest numpy and cython docs

[maxnoe]

Remove all the magic for allowing compilation of bundled c files without Cython, this was obsolete since we python Cython into the build requirements in pyproject.toml. Supporting the case where people don't have cython doesn't make sense, since pip ensures it.

Numpy 1.25 made oldest-supported-numpy obsolete, we can chose the lowest version of numpy we want to support with a definition as long as we compile using at least numpy 1.25.

[orelgueta]

I had to read a bit to figure out why in pyproject.toml you require numpy>=1.25 and in setup.py you require numpy>=1.21 and NPY_1_21_API_VERSION, but I think I understood and it's not a bug, so I approve (the one comment I left is not critical).

[maxnoe]

Dropping python 3.8 required for the numpy >= 1.25 requirement. But according to the NEP 29 schedule, this was overdue anyway and e.g. ctapipe has already done it.

[maxnoe]

I had to read a bit to figure out why in pyproject.toml you require numpy>=1.25 and in setup.py you require numpy>=1.21 and NPY_1_21_API_VERSION, but I think I understood and it's not a bug, so I approve (the one comment I left is not critical).

Yes, this is a bit confusing, but it boils down to:

• numpy 1.25 introduced a new feature of stable C-API / ABI with a selectable lower version of numpy you want to support
• We need to compile the extension against at least 1.25 to make use of this feature, but the resulting compiled extension will be compatible with all numpy versions larger than the one we defined.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72c9715) 86.58% compared to head (ef8d1dd) 86.58%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files          24       24           
  Lines        2222     2222           
=======================================
  Hits         1924     1924           
  Misses        298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[orelgueta]

All good now!