Return back user registration option (registration has been removed in the initial stages) #66
Conversation
AleksandrPo
requested review from
avisnakovs and
olegvm
and removed request for
avisnakovs
src/main/webapp/js/login.js
Outdated
| "username": usernameTxt.value, | ||
| "password": pwd1 | ||
| } | ||
| register(dto) |
There was a problem hiding this comment.
Please don't leave out semicolons at the end of statements, otherwise weird things may happen in some cases.
|
Please expand PR description to a sentence or two. "Registration return" is too short and is ambiguous because of that. |
AleksandrPo
changed the title
src/main/webapp/js/login.js
Outdated
| @@ -25,6 +25,75 @@ function login() { | |||
| }) | |||
| } | |||
|
|
|||
| function collectDto(){ | |||
There was a problem hiding this comment.
At the moment this function does two different things: 1) collects data; 2) sends a registration request. Work with UI-related code and HTTP requests should be implemented in separate functions.
Please extract the code that collects data into a separate function collectData, and rename this function to e.g. collectDataAndRegister to make its purpose clearer.
|
Side note: I see you've updated PR title but not description. The title should be the shorter one, and the description should contain the explanation or comment. |
Checklist
mvn testfrom the root directory to see all new and existing tests passMotivation and Context
#59
Description
Registration return