Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull requests are treated as issues #13

Open
gschare opened this issue Feb 12, 2021 · 2 comments
Open

pull requests are treated as issues #13

gschare opened this issue Feb 12, 2021 · 2 comments
Assignees
@gschare
Labels
bug Something isn't working question Further information is requested

Comments

@gschare
Copy link
Collaborator

gschare commented Feb 12, 2021

The GitHub API returns pull requests in addition to issues when you download the JSON data.
It is trivially possible to distinguish them in the JSON (based on the "pull_request" and "html_url" JSON fields) but the question is: do we want to distinguish these? If so, how?
@gschare gschare added bug Something isn't working question Further information is requested labels Feb 12, 2021
@gschare gschare self-assigned this Feb 12, 2021
@njr2128 njr2128 mentioned this issue Feb 16, 2021
Closed
6 tasks
@gschare
Copy link
Collaborator Author

gschare commented Feb 16, 2021

Commits, assignments, etc. likely show up as "events" in the schema. We might download these as well and include them on each corresponding page.

@njr2128
Copy link
Member

njr2128 commented Feb 22, 2021

DECISION: put issues in one folder and put pulls in another.
INDEX: yes, at this stage - to prototype, distinguish these and possibly index separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gschare gschare

Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@njr2128 @gschare