Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues 1566, 1567, 1568 and others are misplaced in the index of issues #20

Open
gschare opened this issue Apr 14, 2021 · 1 comment
Open
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@gschare
Copy link
Collaborator

gschare commented Apr 14, 2021

Important note: even after redownloading and regenerating, the numbers of issues which were misplaced were consistent.
There is likely actually two different things going on with different causes:

  • certain issues misplaced but still in index (e.g. 1566-1568)
  • certain issues gone entirely (e.g. issue 1587)

A strong theory is implied by the fact that 1566-1568 were transferred from a different repo into m-k-manuscript-data, while 1587 was transferred out to a different repo.

Per Terry, possibilities for the source of the bug:

  • mistake in API request, i.e. getting things in the wrong order
  • API is putting things in the wrong order either purposefully or as a bug in itself
    • if purposeful, this could be because the JSON is sorted not on date of creation but on something else. More likely, though, given the evidence above, the API is in fact sorting correctly on date of creation, because issues which were transferred between repos will be given a new number to fit into the new repo but their date of creation will remain the same as before.
  • bug in Haskell processing
    • we do not sort them; we just take the order given by the JSON from the update.sh script; this would likely fix the symptom

I'm almost entirely convinced it is a matter of transferring issues between repos and only that. In light of that, I am not strongly compelled to programmatically confirm this is the case.
Because we want the index to be sorted by number, not creation date (confirm?) we may simply sort by number in the Haskell processing step.

@gschare gschare added bug Something isn't working question Further information is requested labels Apr 14, 2021
@gschare gschare self-assigned this Apr 14, 2021
@gschare
Copy link
Collaborator Author

gschare commented Apr 14, 2021

Later on, we can add sort options to the index page so that the user can see issues sorted by creation date, alphabetical, number, modification date, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant