Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Windows/Ruby 3.1 with each major childprocess version #871

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 7 additions & 73 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,27 +18,21 @@ env:
JRUBY_OPTS: "--dev"

jobs:
test-ubuntu:
runs-on: ubuntu-latest
test-windows:
runs-on: windows-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ruby/setup-ruby-pkgs

This link mentioned windows-2022 which can be tried, I guess?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if I can get childprocess running CI on Actions.


strategy:
fail-fast: false
matrix:
ruby: ["3.0", "3.1", jruby-9.2, jruby-9.3]
appraisal: [cucumber_7]
include:
- ruby: "2.5"
appraisal: cucumber_4
- ruby: "2.6"
appraisal: cucumber_5
- ruby: "2.7"
appraisal: cucumber_6
- ruby: "3.1"
appraisal: cucumber_8
ruby: ["3.1"]
appraisal: [cucumber_4, cucumber_5, cucumber_6, cucumber_7, cucumber_8]

env:
BUNDLE_GEMFILE: gemfiles/${{ matrix.appraisal }}.gemfile

steps:
- name: git config autocrlf
run: git config --global core.autocrlf false
- uses: actions/checkout@v2
- name: Set up Ruby
uses: ruby/setup-ruby@v1
Expand All @@ -59,63 +53,3 @@ jobs:
bundle install --jobs 4
- name: Run specs
run: bundle exec rake spec
- name: Run cukes
run: bundle exec rake cucumber

test-macos:
strategy:
fail-fast: false
matrix:
ruby: [2.5, 2.6, 2.7, "3.0"]

runs-on: macos-latest

steps:
- uses: actions/checkout@v2
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Run specs
run: bundle exec rake spec
- name: Run cukes
run: bundle exec rake cucumber

test-windows:
strategy:
fail-fast: false
matrix:
ruby: [2.5, 2.6, 2.7, "3.0"]

runs-on: windows-latest

steps:
- name: git config autocrlf
run: git config --global core.autocrlf false
- uses: actions/checkout@v2
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Run specs
run: bundle exec rake spec

checks:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
bundler-cache: true
- name: Install license_finder
run: gem install license_finder
- name: Run linters
run: bundle exec rake lint
- name: Run license_finder
run: license_finder
6 changes: 3 additions & 3 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ end

appraise "cucumber_6" do
gem "cucumber", "~> 6.0"
gem "childprocess", "~> 4.0"
gem "childprocess", "~> 4.0.0"
end

appraise "cucumber_7" do
gem "cucumber", "~> 7.0"
gem "childprocess", "~> 4.0"
gem "childprocess", "~> 4.0.0"
end

appraise "cucumber_8" do
gem "cucumber", "~> 8.0"
gem "childprocess", "~> 4.0"
gem "childprocess", "~> 4.1.0"
end
2 changes: 1 addition & 1 deletion gemfiles/cucumber_6.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
source "https://rubygems.org"

gem "cucumber", "~> 6.0"
gem "childprocess", "~> 4.0"
gem "childprocess", "~> 4.0.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/cucumber_7.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
source "https://rubygems.org"

gem "cucumber", "~> 7.0"
gem "childprocess", "~> 4.0"
gem "childprocess", "~> 4.0.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/cucumber_8.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
source "https://rubygems.org"

gem "cucumber", "~> 8.0"
gem "childprocess", "~> 4.0"
gem "childprocess", "~> 4.1.0"

gemspec path: "../"