Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/simplify test matrix #588

Merged
merged 10 commits into from
Nov 4, 2024
Merged

Conversation

luke-hill
Copy link
Contributor

🤔 What's changed?

Follow up from previous work in #586 to explain the decisions. Move to an include/exclude matrix to cover old/new rubies vs standard ones

⚡️ What's your motivation?

Explain the choices of what combinations to run plus simplify things a little (Removing some redundant combinations in the process).

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)
  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill
Copy link
Contributor Author

cc/ @p8 / @olleolleolle for some updates here (We actually reduce the size of the matrix, but build it in a slightly diff way so you can see "how" it is built better).

@luke-hill luke-hill merged commit d86f2e7 into main Nov 4, 2024
13 checks passed
@luke-hill luke-hill deleted the refactor/simplify_test_matrix branch November 4, 2024 16:57
@luke-hill
Copy link
Contributor Author

ping @p8 this is now merged in. I probably will update the changelog soon as this is a reasonably important change (As we're now 'officially' supporting rails 7.2 - I'll probably also cut a patch version just to signify this also.

@p8
Copy link
Contributor

p8 commented Nov 5, 2024

Thanks @luke-hill !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants