Korean dialect missing space after step keywords (#254)

* fix: korean missing space after keyword * Changelog missing trailing space korean dialect
cucumber · Jul 4, 2024 · b6a7d4f · b6a7d4f
1 parent 47352e3
commit b6a7d4f
Show file tree

Hide file tree

Showing 14 changed files with 101 additions and 100 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,7 +9,8 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
 ## [Unreleased]
 ### Fixed
 - [Python] Provide informative exception for trailing escapes in tables ([#241](https://github.com/cucumber/gherkin/pull/241))
-- (i18n) Provide trailing space in Irish keywords ([#243](https://github.com/cucumber/gherkin/pull/243))
+- (i18n) Provide trailing space in Irish step keywords ([#243](https://github.com/cucumber/gherkin/pull/243))
+- (i18n) Provide trailing space in Korean step keywords ([#254](https://github.com/cucumber/gherkin/pull/254))
 - (i18n) Tamil "And" and "But" translations should have single trailing space ([#243](https://github.com/cucumber/gherkin/pull/243))
 - Intermittent failure of cpp test jobs in CI ([#217](https://github.com/cucumber/gherkin/issues/217))
 

diff --git a/c/src/dialect.c b/c/src/dialect.c
@@ -2115,13 +2115,13 @@ static const Dialect kn_dialect = {
         &kn_then_keywords,
         &kn_when_keywords };
 
-static const wchar_t* const ko_and_KEYWORDS[] = { L"* ", L"그리고" };
+static const wchar_t* const ko_and_KEYWORDS[] = { L"* ", L"그리고 " };
 static const Keywords ko_and_keywords = { 2, ko_and_KEYWORDS };
 
 static const wchar_t* const ko_background_KEYWORDS[] = { L"배경" };
 static const Keywords ko_background_keywords = { 1, ko_background_KEYWORDS };
 
-static const wchar_t* const ko_but_KEYWORDS[] = { L"* ", L"하지만", L"단" };
+static const wchar_t* const ko_but_KEYWORDS[] = { L"* ", L"하지만 ", L"단 " };
 static const Keywords ko_but_keywords = { 3, ko_but_KEYWORDS };
 
 static const wchar_t* const ko_examples_KEYWORDS[] = { L"예" };
@@ -2130,7 +2130,7 @@ static const Keywords ko_examples_keywords = { 1, ko_examples_KEYWORDS };
 static const wchar_t* const ko_feature_KEYWORDS[] = { L"기능" };
 static const Keywords ko_feature_keywords = { 1, ko_feature_KEYWORDS };
 
-static const wchar_t* const ko_given_KEYWORDS[] = { L"* ", L"조건", L"먼저" };
+static const wchar_t* const ko_given_KEYWORDS[] = { L"* ", L"조건 ", L"먼저 " };
 static const Keywords ko_given_keywords = { 3, ko_given_KEYWORDS };
 
 static const wchar_t* const ko_rule_KEYWORDS[] = { L"Rule" };
@@ -2142,10 +2142,10 @@ static const Keywords ko_scenario_keywords = { 1, ko_scenario_KEYWORDS };
 static const wchar_t* const ko_scenarioOutline_KEYWORDS[] = { L"시나리오 개요" };
 static const Keywords ko_scenarioOutline_keywords = { 1, ko_scenarioOutline_KEYWORDS };
 
-static const wchar_t* const ko_then_KEYWORDS[] = { L"* ", L"그러면" };
+static const wchar_t* const ko_then_KEYWORDS[] = { L"* ", L"그러면 " };
 static const Keywords ko_then_keywords = { 2, ko_then_KEYWORDS };
 
-static const wchar_t* const ko_when_KEYWORDS[] = { L"* ", L"만일", L"만약" };
+static const wchar_t* const ko_when_KEYWORDS[] = { L"* ", L"만일 ", L"만약 " };
 static const Keywords ko_when_keywords = { 3, ko_when_KEYWORDS };
 
 static const Dialect ko_dialect = {

diff --git a/cpp/src/lib/gherkin/cucumber/gherkin/dialect.cpp b/cpp/src/lib/gherkin/cucumber/gherkin/dialect.cpp
@@ -729,17 +729,17 @@ all_keywords()
     {
         "ko",
         {
-            { "and", { "* ", "그리고" } },
+            { "and", { "* ", "그리고 " } },
             { "background", { "배경" } },
-            { "but", { "* ", "하지만", "단" } },
+            { "but", { "* ", "하지만 ", "단 " } },
             { "examples", { "예" } },
             { "feature", { "기능" } },
-            { "given", { "* ", "조건", "먼저" } },
+            { "given", { "* ", "조건 ", "먼저 " } },
             { "rule", { "Rule" } },
             { "scenario", { "시나리오" } },
             { "scenarioOutline", { "시나리오 개요" } },
-            { "then", { "* ", "그러면" } },
-            { "when", { "* ", "만일", "만약" } }
+            { "then", { "* ", "그러면 " } },
+            { "when", { "* ", "만일 ", "만약 " } }
         }
     },
     {

diff --git a/dart/assets/gherkin-languages.json b/dart/assets/gherkin-languages.json
@@ -2133,15 +2133,15 @@
   "ko": {
     "and": [
       "* ",
-      "그리고"
+      "그리고 "
     ],
     "background": [
       "배경"
     ],
     "but": [
       "* ",
-      "하지만",
-      "단"
+      "하지만 ",
+      "단 "
     ],
     "examples": [
       "예"
@@ -2151,8 +2151,8 @@
     ],
     "given": [
       "* ",
-      "조건",
-      "먼저"
+      "조건 ",
+      "먼저 "
     ],
     "name": "Korean",
     "native": "한국어",
@@ -2167,12 +2167,12 @@
     ],
     "then": [
       "* ",
-      "그러면"
+      "그러면 "
     ],
     "when": [
       "* ",
-      "만일",
-      "만약"
+      "만일 ",
+      "만약 "
     ]
   },
   "lt": {

diff --git a/dotnet/Gherkin/gherkin-languages.json b/dotnet/Gherkin/gherkin-languages.json
@@ -2133,15 +2133,15 @@
   "ko": {
     "and": [
       "* ",
-      "그리고"
+      "그리고 "
     ],
     "background": [
       "배경"
     ],
     "but": [
       "* ",
-      "하지만",
-      "단"
+      "하지만 ",
+      "단 "
     ],
     "examples": [
       "예"
@@ -2151,8 +2151,8 @@
     ],
     "given": [
       "* ",
-      "조건",
-      "먼저"
+      "조건 ",
+      "먼저 "
     ],
     "name": "Korean",
     "native": "한국어",
@@ -2167,12 +2167,12 @@
     ],
     "then": [
       "* ",
-      "그러면"
+      "그러면 "
     ],
     "when": [
       "* ",
-      "만일",
-      "만약"
+      "만일 ",
+      "만약 "
     ]
   },
   "lt": {

diff --git a/elixir/priv/gherkin_languages.json b/elixir/priv/gherkin_languages.json
@@ -2133,15 +2133,15 @@
   "ko": {
     "and": [
       "* ",
-      "그리고"
+      "그리고 "
     ],
     "background": [
       "배경"
     ],
     "but": [
       "* ",
-      "하지만",
-      "단"
+      "하지만 ",
+      "단 "
     ],
     "examples": [
       "예"
@@ -2151,8 +2151,8 @@
     ],
     "given": [
       "* ",
-      "조건",
-      "먼저"
+      "조건 ",
+      "먼저 "
     ],
     "name": "Korean",
     "native": "한국어",
@@ -2167,12 +2167,12 @@
     ],
     "then": [
       "* ",
-      "그러면"
+      "그러면 "
     ],
     "when": [
       "* ",
-      "만일",
-      "만약"
+      "만일 ",
+      "만약 "
     ]
   },
   "lt": {

diff --git a/gherkin-languages.json b/gherkin-languages.json
@@ -2133,15 +2133,15 @@
   "ko": {
     "and": [
       "* ",
-      "그리고"
+      "그리고 "
     ],
     "background": [
       "배경"
     ],
     "but": [
       "* ",
-      "하지만",
-      "단"
+      "하지만 ",
+      "단 "
     ],
     "examples": [
       "예"
@@ -2151,8 +2151,8 @@
     ],
     "given": [
       "* ",
-      "조건",
-      "먼저"
+      "조건 ",
+      "먼저 "
     ],
     "name": "Korean",
     "native": "한국어",
@@ -2167,12 +2167,12 @@
     ],
     "then": [
       "* ",
-      "그러면"
+      "그러면 "
     ],
     "when": [
       "* ",
-      "만일",
-      "만약"
+      "만일 ",
+      "만약 "
     ]
   },
   "lt": {

diff --git a/go/dialects_builtin.go b/go/dialects_builtin.go
diff --git a/javascript/src/gherkin-languages.json b/javascript/src/gherkin-languages.json
@@ -2133,15 +2133,15 @@
   "ko": {
     "and": [
       "* ",
-      "그리고"
+      "그리고 "
     ],
     "background": [
       "배경"
     ],
     "but": [
       "* ",
-      "하지만",
-      "단"
+      "하지만 ",
+      "단 "
     ],
     "examples": [
       "예"
@@ -2151,8 +2151,8 @@
     ],
     "given": [
       "* ",
-      "조건",
-      "먼저"
+      "조건 ",
+      "먼저 "
     ],
     "name": "Korean",
     "native": "한국어",
@@ -2167,12 +2167,12 @@
     ],
     "then": [
       "* ",
-      "그러면"
+      "그러면 "
     ],
     "when": [
       "* ",
-      "만일",
-      "만약"
+      "만일 ",
+      "만약 "
     ]
   },
   "lt": {