Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean dialect missing space after step keywords #254

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Korean dialect missing space after step keywords #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0151e44
fix: korean missing space after keyword
kieran-ryan Jul 4, 2024
1dd7c5f
Changelog missing trailing space korean dialect
kieran-ryan Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
## [Unreleased]
### Fixed
- [Python] Provide informative exception for trailing escapes in tables ([#241](https://github.com/cucumber/gherkin/pull/241))
- (i18n) Provide trailing space in Irish keywords ([#243](https://github.com/cucumber/gherkin/pull/243))
- (i18n) Provide trailing space in Irish step keywords ([#243](https://github.com/cucumber/gherkin/pull/243))
- (i18n) Provide trailing space in Korean step keywords ([#254](https://github.com/cucumber/gherkin/pull/254))
- (i18n) Tamil "And" and "But" translations should have single trailing space ([#243](https://github.com/cucumber/gherkin/pull/243))
- Intermittent failure of cpp test jobs in CI ([#217](https://github.com/cucumber/gherkin/issues/217))

Expand Down
10 changes: 5 additions & 5 deletions c/src/dialect.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2115,13 +2115,13 @@ static const Dialect kn_dialect = {
&kn_then_keywords,
&kn_when_keywords };

static const wchar_t* const ko_and_KEYWORDS[] = { L"* ", L"그리고" };
static const wchar_t* const ko_and_KEYWORDS[] = { L"* ", L"그리고 " };
static const Keywords ko_and_keywords = { 2, ko_and_KEYWORDS };

static const wchar_t* const ko_background_KEYWORDS[] = { L"배경" };
static const Keywords ko_background_keywords = { 1, ko_background_KEYWORDS };

static const wchar_t* const ko_but_KEYWORDS[] = { L"* ", L"하지만", L"단" };
static const wchar_t* const ko_but_KEYWORDS[] = { L"* ", L"하지만 ", L"단 " };
static const Keywords ko_but_keywords = { 3, ko_but_KEYWORDS };

static const wchar_t* const ko_examples_KEYWORDS[] = { L"예" };
Expand All @@ -2130,7 +2130,7 @@ static const Keywords ko_examples_keywords = { 1, ko_examples_KEYWORDS };
static const wchar_t* const ko_feature_KEYWORDS[] = { L"기능" };
static const Keywords ko_feature_keywords = { 1, ko_feature_KEYWORDS };

static const wchar_t* const ko_given_KEYWORDS[] = { L"* ", L"조건", L"먼저" };
static const wchar_t* const ko_given_KEYWORDS[] = { L"* ", L"조건 ", L"먼저 " };
static const Keywords ko_given_keywords = { 3, ko_given_KEYWORDS };

static const wchar_t* const ko_rule_KEYWORDS[] = { L"Rule" };
Expand All @@ -2142,10 +2142,10 @@ static const Keywords ko_scenario_keywords = { 1, ko_scenario_KEYWORDS };
static const wchar_t* const ko_scenarioOutline_KEYWORDS[] = { L"시나리오 개요" };
static const Keywords ko_scenarioOutline_keywords = { 1, ko_scenarioOutline_KEYWORDS };

static const wchar_t* const ko_then_KEYWORDS[] = { L"* ", L"그러면" };
static const wchar_t* const ko_then_KEYWORDS[] = { L"* ", L"그러면 " };
static const Keywords ko_then_keywords = { 2, ko_then_KEYWORDS };

static const wchar_t* const ko_when_KEYWORDS[] = { L"* ", L"만일", L"만약" };
static const wchar_t* const ko_when_KEYWORDS[] = { L"* ", L"만일 ", L"만약 " };
static const Keywords ko_when_keywords = { 3, ko_when_KEYWORDS };

static const Dialect ko_dialect = {
Expand Down
10 changes: 5 additions & 5 deletions cpp/src/lib/gherkin/cucumber/gherkin/dialect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,17 +729,17 @@ all_keywords()
{
"ko",
{
{ "and", { "* ", "그리고" } },
{ "and", { "* ", "그리고 " } },
{ "background", { "배경" } },
{ "but", { "* ", "하지만", "단" } },
{ "but", { "* ", "하지만 ", "단 " } },
{ "examples", { "예" } },
{ "feature", { "기능" } },
{ "given", { "* ", "조건", "먼저" } },
{ "given", { "* ", "조건 ", "먼저 " } },
{ "rule", { "Rule" } },
{ "scenario", { "시나리오" } },
{ "scenarioOutline", { "시나리오 개요" } },
{ "then", { "* ", "그러면" } },
{ "when", { "* ", "만일", "만약" } }
{ "then", { "* ", "그러면 " } },
{ "when", { "* ", "만일 ", "만약 " } }
}
},
{
Expand Down
16 changes: 8 additions & 8 deletions dart/assets/gherkin-languages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,15 +2133,15 @@
"ko": {
"and": [
"* ",
"그리고"
"그리고 "
],
"background": [
"배경"
],
"but": [
"* ",
"하지만",
"단"
"하지만 ",
"단 "
],
"examples": [
"예"
Expand All @@ -2151,8 +2151,8 @@
],
"given": [
"* ",
"조건",
"먼저"
"조건 ",
"먼저 "
],
"name": "Korean",
"native": "한국어",
Expand All @@ -2167,12 +2167,12 @@
],
"then": [
"* ",
"그러면"
"그러면 "
],
"when": [
"* ",
"만일",
"만약"
"만일 ",
"만약 "
]
},
"lt": {
Expand Down
16 changes: 8 additions & 8 deletions dotnet/Gherkin/gherkin-languages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,15 +2133,15 @@
"ko": {
"and": [
"* ",
"그리고"
"그리고 "
],
"background": [
"배경"
],
"but": [
"* ",
"하지만",
"단"
"하지만 ",
"단 "
],
"examples": [
"예"
Expand All @@ -2151,8 +2151,8 @@
],
"given": [
"* ",
"조건",
"먼저"
"조건 ",
"먼저 "
],
"name": "Korean",
"native": "한국어",
Expand All @@ -2167,12 +2167,12 @@
],
"then": [
"* ",
"그러면"
"그러면 "
],
"when": [
"* ",
"만일",
"만약"
"만일 ",
"만약 "
]
},
"lt": {
Expand Down
16 changes: 8 additions & 8 deletions elixir/priv/gherkin_languages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,15 +2133,15 @@
"ko": {
"and": [
"* ",
"그리고"
"그리고 "
],
"background": [
"배경"
],
"but": [
"* ",
"하지만",
"단"
"하지만 ",
"단 "
],
"examples": [
"예"
Expand All @@ -2151,8 +2151,8 @@
],
"given": [
"* ",
"조건",
"먼저"
"조건 ",
"먼저 "
],
"name": "Korean",
"native": "한국어",
Expand All @@ -2167,12 +2167,12 @@
],
"then": [
"* ",
"그러면"
"그러면 "
],
"when": [
"* ",
"만일",
"만약"
"만일 ",
"만약 "
]
},
"lt": {
Expand Down
16 changes: 8 additions & 8 deletions gherkin-languages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,15 +2133,15 @@
"ko": {
"and": [
"* ",
"그리고"
"그리고 "
],
"background": [
"배경"
],
"but": [
"* ",
"하지만",
"단"
"하지만 ",
"단 "
],
"examples": [
"예"
Expand All @@ -2151,8 +2151,8 @@
],
"given": [
"* ",
"조건",
"먼저"
"조건 ",
"먼저 "
],
"name": "Korean",
"native": "한국어",
Expand All @@ -2167,12 +2167,12 @@
],
"then": [
"* ",
"그러면"
"그러면 "
],
"when": [
"* ",
"만일",
"만약"
"만일 ",
"만약 "
]
},
"lt": {
Expand Down
32 changes: 16 additions & 16 deletions go/dialects_builtin.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions javascript/src/gherkin-languages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,15 +2133,15 @@
"ko": {
"and": [
"* ",
"그리고"
"그리고 "
],
"background": [
"배경"
],
"but": [
"* ",
"하지만",
"단"
"하지만 ",
"단 "
],
"examples": [
"예"
Expand All @@ -2151,8 +2151,8 @@
],
"given": [
"* ",
"조건",
"먼저"
"조건 ",
"먼저 "
],
"name": "Korean",
"native": "한국어",
Expand All @@ -2167,12 +2167,12 @@
],
"then": [
"* ",
"그러면"
"그러면 "
],
"when": [
"* ",
"만일",
"만약"
"만일 ",
"만약 "
]
},
"lt": {
Expand Down
Loading
Loading