You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Assuming folks agree with me, I'm happy to prepare a PR where getAllRedisSubscribers deduplicates all the redisSubscribers using a Set. But I just wanted to double-check I'm not missing something first.
(In my application, I'm pretty sure each redisSubscriber has only one relevant channel, so this doesn't affect me. But it struck me when reading the code.)
The text was updated successfully, but these errors were encountered:
For #365 I've been reading over the reconnect code. If I'm reading https://github.com/cult-of-coders/redis-oplog/blob/master/lib/redis/RedisSubscriptionManager.js correctly:
redisSubscriber
tothis.store[channel]
for multiplechannel
s.redisSubscriber
s, causing onConnect() to reload some subscribers many times.Assuming folks agree with me, I'm happy to prepare a PR where
getAllRedisSubscribers
deduplicates all theredisSubscriber
s using aSet
. But I just wanted to double-check I'm not missing something first.(In my application, I'm pretty sure each
redisSubscriber
has only one relevant channel, so this doesn't affect me. But it struck me when reading the code.)The text was updated successfully, but these errors were encountered: