Allow checking for Subscription initialization #383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to: #369 |
6 tasks
|
@KoenLav can you please add some docs for this. Tests if possible. Thank you! |
|
@StorytellerCZ I've added some docs and tests. Edit: not sure why the test is failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to recognize the Subscription is initialized and then disregard our Tenant check only for those (we apply the Tenant check on the Client as well, so this works for us but isn't really safe).
We also noticed that Meteor.userId() (nor this.userId) can be accessed within the configureRedisOplog cursor function (used for applying the Tenant namespace to a Collection), so I believe this is currently broken (at least for initializing (Redis Oplog-based) Subscriptions).
Hence I think this PR should be seen as further outlining the issue, and discussing possible directions for a solution.