fix(Future Select): remove redundant focus management #5015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I was attempting to remove the page jump when the select is opened and found these focus management things that aren't needed and in some cases cause incorrect behaviour (e.g. pressing up arrow on the trigger was focusing the first item, should be the final item).
This has shown to cause no page jump in our storybook
Before:
https://github.com/user-attachments/assets/4cd87900-6ce9-4670-bdd1-385c772a7bf5
After:
https://github.com/user-attachments/assets/4796c5ac-f011-41e2-bd3d-28cdadb95e51
But when testing in one of our UIs via pnpm link, it was still jumping so I'm not confident that this has fixed that.
Either way, definitely still worth pushing this through.
What
useListBox
hook causing it to always focus the first item in the listenabled
is set to false by default in the Popover.focus
doesn't exist so this wasn't doing anything. I needed to fix this to avoid a focus ring showing when opened via click