fix(TextArea): Refactor autogrow to remove visual jank #5195
+173
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d150600 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dougmacknz
force-pushed
the
KZN-2794/text-area-autogrow-refactor
branch
from
a49ab8d
to
355e2d0
Compare
dougmacknz
force-pushed
the
KZN-2794/text-area-autogrow-refactor
branch
from
355e2d0
to
edfe2c3
Compare
|
(just running chromatic) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor TextArea
autogrowfeature to remove a pretty horrible visual jank.In the future we will be able to a new CSS property
field-sizingto do this natively, but for now we still need to use black magic. Method taken from: https://chriscoyier.net/2023/09/29/css-solves-auto-expanding-textareas-probably-eventually/Bonus: