-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support in react native package to identify user and anonymously identify user #311
Merged
ami-aman
merged 25 commits into
feature/cdp-milestone-track-identify
from
feature/cdp/identify-user
Sep 3, 2024
Merged
chore: add support in react native package to identify user and anonymously identify user #311
ami-aman
merged 25 commits into
feature/cdp-milestone-track-identify
from
feature/cdp/identify-user
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
ami-aman
changed the base branch from
feature/cdp-milestone-one
to
feature/cdp/android
August 29, 2024 11:49
Shahroz16
requested changes
Aug 29, 2024
ami-aman
changed the title
chore: identify user and anonymously identify user
chore: identify user and anonymously identify user using react native package
Sep 2, 2024
ami-aman
changed the title
chore: identify user and anonymously identify user using react native package
chore: add support in react native package to identify user and anonymously identify user
Sep 2, 2024
Base automatically changed from
feature/cdp/android
to
feature/cdp-milestone-one
September 2, 2024 09:38
ami-aman
changed the base branch from
feature/cdp-milestone-one
to
feature/cdp-milestone-track-identify
September 2, 2024 15:04
Shahroz16
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, looks good
ami-aman
merged commit Sep 3, 2024
9cf136d
into
feature/cdp-milestone-track-identify
3 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear ticket https://linear.app/customerio/issue/MBL-451/identify-a-user-react-native
Problem
Identify a user when an identifier is provided
Identify a user when an identifier and traits are provided
Anonymously Identify a user when only traits are provided
Throw error when neither an identifer or traits is provided
Solution
Accept parameters in identify method and process based on the arguments provided.
Sample apps use identify method.