Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support in react native package to identify user and anonymously identify user #311

Merged

Conversation

ami-aman
Copy link
Collaborator

@ami-aman ami-aman commented Aug 29, 2024

Linear ticket https://linear.app/customerio/issue/MBL-451/identify-a-user-react-native

Problem

Identify a user when an identifier is provided
Identify a user when an identifier and traits are provided
Anonymously Identify a user when only traits are provided
Throw error when neither an identifer or traits is provided

Solution

Accept parameters in identify method and process based on the arguments provided.
Sample apps use identify method.

Copy link

github-actions bot commented Aug 29, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • FCM: Build failed. See CI job logs to determine the issue and try re-building.
  • APN: Build failed. See CI job logs to determine the issue and try re-building.

@ami-aman ami-aman changed the base branch from feature/cdp-milestone-one to feature/cdp/android August 29, 2024 11:49
@ami-aman ami-aman requested a review from a team August 29, 2024 11:51
src/customerio-cdp.ts Outdated Show resolved Hide resolved
@ami-aman ami-aman changed the title chore: identify user and anonymously identify user chore: identify user and anonymously identify user using react native package Sep 2, 2024
@ami-aman ami-aman changed the title chore: identify user and anonymously identify user using react native package chore: add support in react native package to identify user and anonymously identify user Sep 2, 2024
@ami-aman ami-aman requested a review from Shahroz16 September 2, 2024 08:08
Base automatically changed from feature/cdp/android to feature/cdp-milestone-one September 2, 2024 09:38
@ami-aman ami-aman changed the base branch from feature/cdp-milestone-one to feature/cdp-milestone-track-identify September 2, 2024 15:04
Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, looks good

Apps/FCM/ios/Podfile.lock Show resolved Hide resolved
@ami-aman ami-aman merged commit 9cf136d into feature/cdp-milestone-track-identify Sep 3, 2024
3 of 9 checks passed
@ami-aman ami-aman deleted the feature/cdp/identify-user branch September 3, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants