Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed identify method in android native module #316

Merged

Conversation

ami-aman
Copy link
Collaborator

@ami-aman ami-aman commented Sep 3, 2024

Linear ticket - https://linear.app/customerio/issue/MBL-453/[android]-update-native-module-to-use-identify-using-android-cdp-sdk

This PR addresses an issue with the Android native module’s identify method, correcting the code implementation to make sure it functions as expected.

Copy link

github-actions bot commented Sep 3, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • FCM: Build failed. See CI job logs to determine the issue and try re-building.
  • APN: Build failed. See CI job logs to determine the issue and try re-building.

@ami-aman ami-aman requested a review from a team September 3, 2024 13:11
Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ami-aman ami-aman merged commit c48ec7a into feature/cdp-milestone-track-identify Sep 3, 2024
3 of 11 checks passed
@ami-aman ami-aman deleted the feature/identify-android branch September 3, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants