Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create readme file to help with building and running sample apps #370

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

mahmoud-elmorabea
Copy link
Contributor

This PR adds a readme file to our sample apps to help with instructions for building and running sample apps.

@mahmoud-elmorabea mahmoud-elmorabea self-assigned this Jan 5, 2025
Copy link

github-actions bot commented Jan 5, 2025

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • APN: 370.3.0 (28936365)
  • FCM: 370.3.0 (28936365)

@mahmoud-elmorabea mahmoud-elmorabea requested a review from a team January 5, 2025 15:08
@mahmoud-elmorabea mahmoud-elmorabea requested review from mrehan27 and a team January 6, 2025 09:54
Apps/README.md Outdated

## Connect the app to a workspace in Customer.io

Make a copy of `env.sample.js` by running `cp env.sample.js env.js` at sample app root directory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to copy Env.swift.example as well, otherwise iOS apps will not compile. Also, there are no instructions for signing iOS app, adding them will be helpful for anyone from CIO setting it up the first time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you suggesting for iOS signing? Downloading the provisioning profiles you mean? Otherwise, everything should already be setup

Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@mahmoud-elmorabea mahmoud-elmorabea merged commit 1be1c0e into main Jan 6, 2025
9 checks passed
@mahmoud-elmorabea mahmoud-elmorabea deleted the run-sample-apps-read-me branch January 6, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants