Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allows for non-editable build #9

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

allows for non-editable build #9

wants to merge 1 commit into from

Conversation

ducha-aiki
Copy link
Contributor

No description provided.

@ducha-aiki
Update setup.py
45c951f 
It allows for non-editable build:
`pip install .`
@ducha-aiki ducha-aiki marked this pull request as draft April 14, 2023 17:22
@ducha-aiki
Copy link
Contributor Author

Actually, this is enough for the package, but not data and config files, let me update them as well

@B1ueber2y
Copy link
Member

Hey thanks! Is this still working in progress?

@ducha-aiki
Copy link
Contributor Author

Yes. It actually requires much more work than I thought, because many weights loading and import operations relies on the editable install - and not only limap, but submodules as well...

zhangshaos pushed a commit to zhangshaos/limap that referenced this pull request Jul 12, 2023
@B1ueber2y
Port essential and fundamental matrix (cvg#9)
f0d0157 
* endpoints triangulation as an option. port output folder.

* fix depth-based scoring for endpoints triangulation.

* bind essential and fundamental matrix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ducha-aiki @B1ueber2y